Skip to content

fix(utilities): skip invalid style attributes #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2021

Conversation

dogriffiths
Copy link
Contributor

@dogriffiths dogriffiths commented Jun 11, 2021

Fixes #256

What is the motivation for this pull request?

What is the current behavior?

What is the new behavior?

Checklist:

  • Tests
  • Documentation
  • Types

Copy link
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dogriffiths Thanks for opening this PR!

It looks good overall. I left some comments and can you fix lint errors?

npm run lint:fix

@remarkablemark
Copy link
Owner

Also, do you think the README should be updated?

@remarkablemark remarkablemark added the bug Something isn't working label Jun 12, 2021
@remarkablemark remarkablemark changed the title fix(utilities): skip corrupted style attributes fix(utilities): skip invalid style attributes Jun 12, 2021
@remarkablemark
Copy link
Owner

@dogriffiths would you be able to help get the build green so I can move this PR forward?

@coveralls
Copy link

coveralls commented Aug 12, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 49e00cf on dogriffiths:master into b0c1ca0 on remarkablemark:master.

Copy link
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this @dogriffiths!

@remarkablemark remarkablemark merged commit 1ed58a1 into remarkablemark:master Aug 12, 2021
@remarkablemark
Copy link
Owner

Published v1.2.8:

npm:

Yarn:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throws error when styles are corrupted
3 participants