fix: trim only when necessary if trimming is off

[vidhu]

Fixes #384

What is the motivation for this pull request?

Fixes an issue #384 where trimming can lead to inaccurate parsing when nodes have whitespace characters

What is the current behavior?

• if trim is off, whitespace characters trigger reacts validation errors
• if trim is on, whitespaces are stripped from nodes that can contain white spaces which results in inaccurate parsing

What is the new behavior?

Regardless of the trimming setting, if a text node appears in a node that can contain text nodes eg <table>, <tr>, it will be removed. If trimming is off, then whitespaces are preserved in nodes that can contain text nodes.

Checklist:

• Conventional Commits
• Tests
• Documentation
• Types

Looking for approvals before I add to documentation!

[codecov-commenter]

Codecov Report

Merging #394 (4126592) into master (ec61f9e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #394   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          158       162    +4     
  Branches        55        54    -1     
=========================================
+ Hits           158       162    +4     

Impacted Files	Coverage Δ
lib/dom-to-react.js	100.00% <100.00%> (ø)
lib/utilities.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec61f9e...4126592. Read the comment docs.

[remarkablemark]

Left comments

[vidhu]

Left comments

Thank you! I've resolved the ones I've fixed and replied to your other comments

[remarkablemark]

Looks good! Will you be updating docs @vidhu?

[vidhu]

Looks good! Will you be updating docs @vidhu?

Yes! Just pushed out a commit to update the docs.

[remarkablemark]

Left comments

[vidhu]

Thank you @remarkablemark I've addressed your requested changes

[remarkablemark]

Thanks, looks good @vidhu!

[remarkablemark]

Released in #395 (comment)

[vidhu]

Thank you! Pleasure working with you :)

[remarkablemark]

Same here! @vidhu If you're ever interested in being a maintainer for html-react-parser, I'd be happy to extend the offer.

[vidhu]

Thank you. I would be interested in that. Do you use any instant messaging platform like discord?

[remarkablemark]

Yes! We have a Discord server, feel free to DM me once you join