add support for custom styles beginning with "--*"

[samikarak]

see #81

[coveralls]

Coverage decreased (-0.01%) to 99.281% when pulling 58dd941 on samikarak:master into 9eeef55 on remarkablemark:master.

[remarkablemark]

Thanks for opening the PR @samikarak. Do you mind resolving the comments and adding tests?

[remarkablemark]

chore: s/customStyle/custom properties?

[remarkablemark]

fix: do you mind testing the match using regex since startsWith is not supported in IE?

// regex that matches custom property or no hyphen
var CUSTOM_PROPERTY_OR_NO_HYPHEN_REGEX = /^--[a-zA-Z]+$|^[^-]+$/;

function camelCase(string) {
  // ...

  if (CUSTOM_PROPERTY_OR_NO_HYPHEN_REGEX.test(string)) {
    return string;
  }

  // ...

[samikarak]

seems to not work with custom styles having lisp-case/dash-case in between ...

for example:

CUSTOM_PROPERTY_OR_NO_HYPHEN_REGEX.test('customStyle') // returns : true
CUSTOM_PROPERTY_OR_NO_HYPHEN_REGEX.test('--customStyle') // returns : true
CUSTOM_PROPERTY_OR_NO_HYPHEN_REGEX.test('--custom-style') // returns : false

I think it should also be possible to use custom style having dashes in between (e.g. '--custom-style'). Therefore lets consider an easier approach:

// customStyle or no hyphen found
  if (string.indexOf('--') === 0 || string.indexOf('-') === -1) {
    return string;
  }

It could be possible to use a regex for this check, or to directly replace the string by camelCase if needed, but since javascript does not fully support lookbehind-assertions, the regex gets a little tricky ...

[remarkablemark]

Good point about the lisp-case. What about the modified regex?

-var CUSTOM_PROPERTY_OR_NO_HYPHEN_REGEX = /^--[a-zA-Z]+$|^[^-]+$/;
+var CUSTOM_PROPERTY_OR_NO_HYPHEN_REGEX = /^--[a-zA-Z-]+$|^[^-]+$/;

The indexOf also works, but do you think it's worth making the declaration value check strict?

[remarkablemark]

Just a heads up, I pushed some commits to master so feel free to rebase your branch:

$ git pull --rebase https://github.com/remarkablemark/html-react-parser.git master
$ git push origin master --force

[remarkablemark]

Also, do you mind updating your commit messages to use the conventional commit format?

feat(utilities): add support for custom styles beginning with "--*"

It uses the commit type to help with releasing (otherwise, the version bump wouldn't be correct).

[remarkablemark]

@samikarak Did you accidentally close this PR?

[samikarak]

I had to rebase my fork (I had some issues with some workspace files) and requested another PR. This PR got closed automatically. Lets continue on the new PR

[remarkablemark]

Sounds good, thanks for the update @samikarak