support moved block #22
Merged
+503
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihiro17
approved these changes
Sep 22, 2023
Contributor
akihiro17
left a comment
akihiro17
left a comment
There was a problem hiding this comment.
すいません。遅れました。1個消しても良さそうなコードあったのでコメントしました。
internal/terraform/plan.go
Outdated
| Header() string | ||
| } | ||
|
|
||
| type Config struct { |
Contributor
There was a problem hiding this comment.
もうこの構造体いらないと思うので削除した方が良いと思いました。
| ` | ||
|
|
||
| // These attributes are important (https://github.com/hashicorp/terraform/blob/v1.5.6/internal/command/jsonformat/computed/renderers/block.go#L19-L23) | ||
| var importantAttributes = []string{ |
Contributor
There was a problem hiding this comment.
[Q] moved blockにはっこのimportantとされているattributeのみが差分として表示されるという理解であっているでしょうか。
Collaborator
Author
|
I release v0.0.8 includes this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pull Request to support moved block ( hashicorp/terraform-json#95 ) is merged, so terraform-j2md supports moved block too.
The terraform-json doesn't have a release that includes PR to support moved block yet, so I use main branch temporarily.
#9