Skip to content

feat(render): Use react-dom/server.edge on edge environments #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

feat(render): Use react-dom/server.edge on edge environments #2225

wants to merge 13 commits into from
+241 −50

Conversation

gabrielmfern
Copy link
Collaborator

@gabrielmfern gabrielmfern commented May 7, 2025 •
edited
Loading

Currently it errors with

(rsc)/./node_modules/@react-email/render/dist/edge-light/index.js
 ⨯ Error [TypeError]: Cannot set properties of undefined (setting 'recentlyCreatedOwnerStacks')
    at new Promise (<anonymous>)
    at Generator.next (<anonymous>)

when running with nextjs on the edge

@gabrielmfern gabrielmfern self-assigned this May 7, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 72bfa81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented May 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2025 2:37pm
react-email-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2025 2:37pm

@gabrielmfern gabrielmfern mentioned this pull request May 7, 2025
Closed
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 7, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/resend/react-email/@react-email/render@2225

commit: 72bfa81

@gabrielmfern gabrielmfern force-pushed the canary branch 6 times, most recently from 2eba90b to 98c3d9b Compare May 16, 2025 13:02
@gabrielmfern gabrielmfern force-pushed the canary branch 3 times, most recently from 0074ddf to f7e553f Compare May 20, 2025 14:39
@gabrielmfern gabrielmfern marked this pull request as ready for review May 21, 2025 16:03
@gabrielmfern gabrielmfern force-pushed the feat/use-react-dom-edge-export branch from 201fd73 to b5b9089 Compare May 21, 2025 16:08
@gabrielmfern gabrielmfern changed the base branch from canary to main May 21, 2025 16:08
@gabrielmfern gabrielmfern marked this pull request as draft May 28, 2025 14:29
@gabrielmfern gabrielmfern changed the title feat(render): Use react-dom/server.edge in a new edge-light export feat(render): Use react-dom/server.edge on edge environments Jun 2, 2025
@gabrielmfern gabrielmfern force-pushed the feat/use-react-dom-edge-export branch from b5b9089 to bb0049a Compare June 2, 2025 12:17
@evadecker evadecker mentioned this pull request Jun 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gabrielmfern gabrielmfern

Labels
Package: @react-email/render
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gabrielmfern