Skip to content

feat!: use req.log on audit plugin #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2023
Merged

feat!: use req.log on audit plugin #1938

merged 2 commits into from
Jan 17, 2023

Conversation

mmarchini
Copy link
Contributor

So it's consistent with other plugins, and to allow child loggers
attached to req to be used on audit.

Pre-Submission Checklist

  • Opened an issue discussing these changes before opening the PR
  • Ran the linter and tests via make prepush
  • Included comprehensive and convincing tests for changes

Issues

Closes:

  • Issue #
  • Issue #
  • Issue #

Summarize the issues that discussed these changes

Changes

What does this PR do?

@mmarchini
feat!: use req.log on audit plugin
6123059 
So it's consistent with other plugins, and to allow child loggers
attached to req to be used on audit.
@mmarchini
feat!: don't override req.log if set during .first
60a77ca
@mmarchini mmarchini merged commit 852d2c1 into restify:master Jan 17, 2023
@mmarchini mmarchini deleted the use-req-log-on-audit branch January 17, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephharrington josephharrington josephharrington approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmarchini @josephharrington