New Updates #1
Open
New Updates #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_trading_week() bug fix
oops!
Just adding this here because I always bloody lose it.
For example it can be used to save a lot of bandwidth, storage requirements and initialization time.
Moved the login credentials into settings where they can be easily found and adjusted. Added ability to specify live/demo account. without this "live" was hard-coded into code and made it impossible to use application with a demo account. Also added exception handling in order to actually display the login error to the user. Before this it failed silently, very confusing and time consuming to debug.
…rt application. Docker image can be built with basic configuraiton off the repository, or with an additional phpmyadmin package. The user just needs to specify the FXCM credentials and the symbols to track.
Preventing a crash due to integer bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Richwu,
Please update your code to the new version.
Thanks
James