Go vet #16
Closed
Go vet #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a conflation of types between a filename and the *config.Config (source and target). The fmt was using a %s and meant the filename but used the nil *config.Config Removed an erroneous strconv.Itoa. The fmt was using %d anyway.
Author
|
I don't think I did this PR right. I only meant for commit d00ed27 to be in. I'm new to git and blundering my way around. Not sure how to correct this. |
Author
|
That was embarrassing but educational. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up issues raised by go vet (they were real). Note that I change tmp to tmp_fn for consistency.