Skip to content

refactor typesupport #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2015
Merged

refactor typesupport #172

merged 1 commit into from
Dec 12, 2015

Conversation

@dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Dec 8, 2015

@dirk-thomas dirk-thomas added the in progress Actively being worked on (Kanban column) label Dec 8, 2015
@dirk-thomas dirk-thomas self-assigned this Dec 8, 2015
@dirk-thomas dirk-thomas force-pushed the refactor_typesupport branch 4 times, most recently from 3505d6a to 1e5db72 Compare December 11, 2015 01:32
wjwwood
wjwwood reviewed Dec 11, 2015
View reviewed changes
rclcpp/cmake/get_rclcpp_information.cmake Outdated
Copy link
Member

@wjwwood wjwwood Dec 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left over messages.

Copy link
Member Author

@dirk-thomas dirk-thomas Dec 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gone.

@dirk-thomas dirk-thomas force-pushed the refactor_typesupport branch 4 times, most recently from dd9468b to 8f6e430 Compare December 11, 2015 20:11
@dirk-thomas dirk-thomas mentioned this pull request Dec 11, 2015
Closed
@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 11, 2015
@tfoote tfoote mentioned this pull request Dec 11, 2015
Merged
@tfoote tfoote mentioned this pull request Dec 12, 2015
Closed
dirk-thomas added a commit that referenced this pull request Dec 12, 2015
@dirk-thomas
Merge pull request #172 from ros2/refactor_typesupport
9cd129c 
refactor typesupport
@dirk-thomas dirk-thomas merged commit 9cd129c into master Dec 12, 2015
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Dec 12, 2015
@jacquelinekay jacquelinekay deleted the refactor_typesupport branch January 15, 2016 00:12
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
@gaoethan @wjwwood
Out-of-scope memory use and memory leak issue (ros2#172)
f7d7df6 
* * out-of-scope memory use and memory leak issue

temp going out of scope leaks the storage it points to
resource leak from local_namespace_

Signed-off-by: Ethan Gao <[email protected]>

* exclude the memory free when the namespace given is null

Signed-off-by: Ethan Gao <[email protected]>
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
@wjwwood
re-reduce scope of temp variable (ros2#175)
ffcfc34 
follow up to ros2#172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dirk-thomas dirk-thomas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dirk-thomas @wjwwood