Add gtests, comply to uncrustify, don't build on Windows

[jacquelinekay]

http://ci.ros2.org/job/ros2_batch_ci_linux/236
http://ci.ros2.org/job/ros2_batch_ci_osx/155
http://ci.ros2.org/job/ros2_batch_ci_windows/238

[tfoote]

linux build 232 seems to have been deleted?

[tfoote]

is this ready for review? it's marked as blocking ros2/demos#7

[jacquelinekay]

Yeah, those are old builds. I've updated the links in the description. They are double-referenced from ros2/examples#49

[jacquelinekay]

CI update:
OSX green (this package is ignored in OSX)
Windows red, but the state appears consistent with master (connext_dynamic tests fail) (this package is ignored in Windows)

Linux job is pending:
http://ci.ros2.org/job/ros2_batch_ci_linux/236

[dirk-thomas]

The Windows build should not break. I don't think this is the case for master currently. How do you get to that conclusion?

[jacquelinekay]

I was mistaken, I looked at an earlier master branch build that was red, but it was using the ros2.repos from my other PR (so it obviously didn't compile):

this is the latest Windows build for this branch:

http://ci.ros2.org/job/ros2_batch_ci_windows/238/

[tfoote]

+1

[dirk-thomas]

Looking at the merged code it seems to have some style problems but the CI jobs don't show that. Now sure why that is the case.

[jacquelinekay]

Are you talking about the inconsistent open brace placement?

Yeah, it looks weird. I can try to fix it by hand, I guess.

[dirk-thomas]

And the white spaces in CMake. I am wondering why it didn't came up in the CI jobs. Have you confirmed that the tests (including the linters) are actually being run?

[jacquelinekay]

The gtests ran and passed on the Linux job for this branch:

http://ci.ros2.org/job/ros2_batch_ci_linux/236/testReport/%28root%29/TestApi/

I'm not sure how to check if the linters ran on Jenkins for specific files.

I have been running ament_uncrustify locally on source files and it says
there are no errors for this repo. However, I just learned that
ament_lint_cmake exists, ran it locally on the CMakeLists.txt for this
repo, and found style errors.

So, yes, linters are not running for this package on Jenkins. How do I fix
that?

On Fri, Aug 21, 2015 at 11:17 AM, Dirk Thomas [email protected]
wrote:

And the white spaces in CMake. I am wondering why it didn't came up in the
CI jobs. Have you confirmed that the tests (including the linters) are
actually being run?

—
Reply to this email directly or view it on GitHub
#2 (comment).

[dirk-thomas]

You must call find_package(ament_lint_auto REQUIRED) before ament_package() otherwise it does not get triggered.

[dirk-thomas]

This should be checked automatically: ament/ament_lint#26

[jacquelinekay]

/pull/3