Make message clearer when specifying default rmw implementation #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| set(RMW_IMPLEMENTATION "${default_rmw_implementation}") | ||
| message(STATUS "Using RMW implementation: ${RMW_IMPLEMENTATION}") | ||
| message(STATUS "Using RMW implementation '${RMW_IMPLEMENTATION}' as default.") |
Member
There was a problem hiding this comment.
Commonly these messages don't have a trailing dot
Member
|
Beside the minor comment this lgtm. |
Member
|
Merged with 2ffb868 |
Member
Author
|
Thanks for fixing that @wjwwood |
ivanpauno
pushed a commit
that referenced
this pull request
Jan 2, 2020
use target_compile_definitions instead of set_target_properties
mauropasse
pushed a commit
to mauropasse/rmw_implementation
that referenced
this pull request
Mar 10, 2021
Rework executor callback data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was a bit vague before about what it was doing