Symplify rmw interface implementation when multi DDS found #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit use classic c preprocessor approch to handle variadic parameter, which define RMW interface implementation and handle ARG values inside RMW_INTERFACE_FN macro. It obviously reduce code lines and complexity of rmw interface implementation.
Member
|
Thank you for the patch. That indeed significantly decreased the code size. I applied some minor changes on top in c685508. I created #29 and triggered some CI builds. It looks like the code doesn't compile on Windows as-is. Could you have a look on how it can be made to work on Windows since we need to support all platforms? |
dirk-thomas
added
in progress
Author
|
The reason for Windows compile failure lie in the MACRO parse order in a MACRO function and MACRO paramater, like MACRO_FUNC(MACRO_PARAM). In VS, it parse MACRO_FUNC first, but GCC parse MACRO_PARAM firstly. It can be easily resolved #define EXPAND(x) x, which cater both VS and GCC. |
Member
|
Can you commit a patch to this branch? I can then cherry-pick it into the other PR. |
The compile issue is caused by different MACRO parse order between VS and GCC. VS first parse macro function, but GCC take macro parameter priority. Use a empty EXPAND macro to cater both of them.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit use classic c preprocessor approch to handle variadic parameter. By define
RMW interface implementation and handle ARG values inside RMW_INTERFACE_FN macro,
it obviously reduce code lines and complexity of rmw interface implementation.