Skip to content

Conversation

@dirk-thomas dirk-thomas self-assigned this Aug 19, 2015
@dirk-thomas dirk-thomas added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Aug 19, 2015
@esteve
Copy link
Member

esteve commented Aug 19, 2015

+1

@dirk-thomas dirk-thomas force-pushed the add_executable_for_each_rmw_implementations branch from 38d5540 to d9bb1ee Compare August 19, 2015 18:12
@tfoote
Copy link

tfoote commented Aug 19, 2015

+1

Is there a recommended way to use this with a gtest target? Running unit tests against all platforms should be our recommendation, it would be good to make that easy.

@dirk-thomas
Copy link
Member Author

The function only creates executables (hence add_executable_*). A similar function for tests would be possible but also imply a run dependency on e.g. gtest which I would avoid for something like rmw_implementation.

dirk-thomas added a commit that referenced this pull request Aug 19, 2015
…ations

add add_executable_for_each_rmw_implementations()
@dirk-thomas dirk-thomas merged commit 19d1698 into master Aug 19, 2015
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Aug 19, 2015
@dirk-thomas dirk-thomas deleted the add_executable_for_each_rmw_implementations branch August 19, 2015 19:50
@tfoote
Copy link

tfoote commented Aug 19, 2015

Yeah, this would be an additional helper function. Can we provide an iterator/helper method instead to feed into a foreach block?

@dirk-thomas
Copy link
Member Author

I think it would require quite some changes to make the function produce gtest executables and also register them for tests. It is already possible to iterate all generated targets after calling this function. May be that is a better approach to extend its behavior.

@tfoote
Copy link

tfoote commented Aug 19, 2015

Yeah,

Maybe just a function to load the various middlewares turning this into a one liner:

  # get the rmw implementations ahead of time
  get_available_rmw_implementations(middleware_implementations)
  foreach(middleware_impl ${middleware_implementations})
    find_package("${middleware_impl}" REQUIRED)
  endforeach()

Such that we can recommend doing the below and using the variable:

  # create executables
  foreach(middleware_impl ${middleware_implementations})
    ...

mauropasse pushed a commit to mauropasse/rmw_implementation that referenced this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants