-
Notifications
You must be signed in to change notification settings - Fork 54
add add_executable_for_each_rmw_implementations() #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add add_executable_for_each_rmw_implementations() #3
Conversation
|
+1 |
38d5540 to
d9bb1ee
Compare
|
+1 Is there a recommended way to use this with a gtest target? Running unit tests against all platforms should be our recommendation, it would be good to make that easy. |
|
The function only creates executables (hence |
…ations add add_executable_for_each_rmw_implementations()
|
Yeah, this would be an additional helper function. Can we provide an iterator/helper method instead to feed into a foreach block? |
|
I think it would require quite some changes to make the function produce gtest executables and also register them for tests. It is already possible to iterate all generated targets after calling this function. May be that is a better approach to extend its behavior. |
|
Yeah, Maybe just a function to load the various middlewares turning this into a one liner: Such that we can recommend doing the below and using the variable: |
…cutor Add events support
http://ci.ros2.org/job/ros2_batch_ci_linux/226/
http://ci.ros2.org/job/ros2_batch_ci_osx/147/
http://ci.ros2.org/job/ros2_batch_ci_windows/227/