moving cmake logic to separate package in the rmw repository #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
The package doesn't seem to have an exec dependency on rmw_implementation_cmake right now?
Member
Author
There was a problem hiding this comment.
You're right, I'll fix that.
Member
|
lgtm |
Member
|
+1 |
wjwwood
added a commit
that referenced
this pull request
Nov 6, 2015
moving cmake logic to separate package in the rmw repository
mauropasse
pushed a commit
to mauropasse/rmw_implementation
that referenced
this pull request
Jan 21, 2021
Rename set_events_executor_callback->set_listener_callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rclcpp#48
Needed as part of the Windows unresolved symbol workaround, see: ros2/rclcpp#48 (comment)