RSpec/VerifiedDoubles: fix detection of nameless doubles #2112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushi-as
force-pushed
the
fix-detection-of-nameless-doubles
branch
from
8bb3a46 to
1667b51
Compare
ydah
added a commit
that referenced
this pull request
Oct 2, 2025
While reviewing the following PR, I noticed that there is no documentation for cop_config in the relevant Cop, so I will add it. - #2112
5 tasks
|
Let me have a look at the failing CI. It seems unrelated to your changes. |
|
CI is fixed now. Please try rebasing on |
ydah
added a commit
that referenced
this pull request
Oct 2, 2025
While reviewing the following PR, I noticed that there is no documentation for cop_config in the relevant Cop, so I will add it. - #2112
ushi-as
force-pushed
the
fix-detection-of-nameless-doubles
branch
from
1667b51 to
bf983d6
Compare
|
@bquorning thx for fixing the CI. I rebased on master. |
bquorning
approved these changes
Oct 5, 2025
ydah
approved these changes
Oct 5, 2025
|
Could you please review the test coverage? Add tests as needed. |
pirj
reviewed
Oct 6, 2025
ushi-as
force-pushed
the
fix-detection-of-nameless-doubles
branch
from
bf983d6 to
87b00cb
Compare
ushi-as
force-pushed
the
fix-detection-of-nameless-doubles
branch
from
87b00cb to
0549bae
Compare
ydah
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The detection of nameless doubles is broken, when methods are specified. This PR fixes it.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml.Enabled: pendinginconfig/default.yml.Enabled: truein.rubocop.yml.VersionAdded: "<<next>>"indefault/config.yml.If you have modified an existing cop's configuration options:
VersionChanged: "<<next>>"inconfig/default.yml.