Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 66 additions & 2 deletions docs/modules/ROOT/pages/cops_rspec.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -6598,18 +6598,82 @@ Prefer using verifying doubles over normal doubles.
----
# bad
let(:foo) do
double(method_name: 'returned value')
double("ClassName", method_name: 'returned value')
end

# bad
let(:foo) do
double("ClassName", method_name: 'returned value')
spy("ClassName", method_name: 'returned value')
end

# good
let(:foo) do
instance_double("ClassName", method_name: 'returned value')
end

# good
let(:foo) do
class_double("ClassName", method_name: 'returned value')
end

# good
let(:foo) do
object_double("some object", method_name: 'returned value')
end
----

[#_ignorenameless_-true-_default__-rspecverifieddoubles]
==== `IgnoreNameless: true (default)`

[source,ruby]
----
# good
let(:foo) do
double(method_name: 'returned value')
end

# good
let(:foo) do
double
end
----

[#_ignorenameless_-false_-rspecverifieddoubles]
==== `IgnoreNameless: false`

[source,ruby]
----
# bad
let(:foo) do
double(method_name: 'returned value')
end

# bad
let(:foo) do
double
end
----

[#_ignoresymbolicnames_-false-_default__-rspecverifieddoubles]
==== `IgnoreSymbolicNames: false (default)`

[source,ruby]
----
# bad
let(:foo) do
double(:foo)
end
----

[#_ignoresymbolicnames_-true_-rspecverifieddoubles]
==== `IgnoreSymbolicNames: true`

[source,ruby]
----
# good
let(:foo) do
double(:foo)
end
----

[#configurable-attributes-rspecverifieddoubles]
Expand Down
48 changes: 46 additions & 2 deletions lib/rubocop/cop/rspec/verified_doubles.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,63 @@ module RSpec
# @example
# # bad
# let(:foo) do
# double(method_name: 'returned value')
# double("ClassName", method_name: 'returned value')
# end
#
# # bad
# let(:foo) do
# double("ClassName", method_name: 'returned value')
# spy("ClassName", method_name: 'returned value')
# end
#
# # good
# let(:foo) do
# instance_double("ClassName", method_name: 'returned value')
# end
#
# # good
# let(:foo) do
# class_double("ClassName", method_name: 'returned value')
# end
#
# # good
# let(:foo) do
# object_double("some object", method_name: 'returned value')
# end
#
# @example `IgnoreNameless: true (default)`
# # good
# let(:foo) do
# double(method_name: 'returned value')
# end
#
# # good
# let(:foo) do
# double
# end
#
# @example `IgnoreNameless: false`
# # bad
# let(:foo) do
# double(method_name: 'returned value')
# end
#
# # bad
# let(:foo) do
# double
# end
#
# @example `IgnoreSymbolicNames: false (default)`
# # bad
# let(:foo) do
# double(:foo)
# end
#
# @example `IgnoreSymbolicNames: true`
# # good
# let(:foo) do
# double(:foo)
# end
#
class VerifiedDoubles < Base
MSG = 'Prefer using verifying doubles over normal doubles.'
RESTRICT_ON_SEND = %i[double spy].freeze
Expand Down
16 changes: 16 additions & 0 deletions spec/rubocop/cop/rspec/verified_doubles_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,20 @@
end
RUBY
end

it 'ignores class_doubles' do
expect_no_offenses(<<~RUBY)
it do
foo = class_double("Foo")
end
RUBY
end

it 'ignores object_doubles' do
expect_no_offenses(<<~RUBY)
it do
foo = object_double("Foo")
end
RUBY
end
end