No std support #150
Open
No std support #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add std feature which defaults on modules map and orswot gated behind std crate is no_std when not std
|
Looks good! Do you need Map/Orswot in your work? I'm a bit wary to bring on another dependency. Perhaps we can make it an optional dependency if a no_std feature is enabled? |
|
Nope, for my use I'll be using lwwreg and vclock. Perhaps a hashbrown feature to opt into it, rather than somewhat obscuring it behind no_std? I don't know if there is any reason besides no_std environments where's useful, but nothing else would need to be behind a no_std feature. |
|
No changes needed post-stabilization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch std imports to core or alloc where possible. Add std feature which defaults on. Modules map and orswot are gated behind std. Everything else works with no other changes.
map and orswot could be supported in no_std if the std hashmap was replaced with hashbrown's hashmap, but I figured I'd make the more conservative change first.
This PR currently requires nightly for error in core which will stabilize in 1.81, this is why the PR is marked draft. The error related parts of this PR could be gated behind a nightly feature and then be merged now, but I don't think there's a rush and the PR can just wait till 1.81 is released.