Skip to content

Conversation

jedisct1
Copy link
Contributor

No description provided.

@KodrAus
Copy link
Contributor

KodrAus commented Sep 18, 2017

Thanks @jedisct1!

This depends on zesterer/spin-rs#42

@KodrAus
Copy link
Contributor

KodrAus commented Sep 25, 2017

This looks good to me. @Kimundi are we ok to merge this and push out a point release?

@KodrAus
Copy link
Contributor

KodrAus commented Sep 26, 2017

Another fix for this I think would be #55 which removes the need for this feature flag.

@Kimundi Kimundi merged commit 4daab9f into rust-lang-nursery:master Sep 28, 2017
@Kimundi
Copy link
Contributor

Kimundi commented Sep 28, 2017

Looks good, thanks!

@joshlf
Copy link

joshlf commented Sep 28, 2017

Looks like this might not be sufficient - since the version of spin that's required is just 0.4, existing Cargo.lock files with 0.4.5 or below will still cause breakage because spin only fixed this issue in 0.4.6.

@sfackler
Copy link

It seems pretty expected that people may have to update dependencies to fix bugs?

@joshlf
Copy link

joshlf commented Sep 28, 2017

Well right now, this will just show itself as a compilation failure - it wouldn't be obvious that updating to a newer version would fix things. If we changed the dependency to spin = 0.4.6, then it would show itself as a failure to resolve dependencies, which would make it very obvious what needed to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants