[Feature] Log flushing and Love2D integration #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemeted log flusing: it stores logs and writes to logfile on demand. This helps performance because file operations are locking. Using `love.filesystem` if exist instead `io`.
For API usage, log functions return string.
Author
|
Saw #12. It gives me an idea of having more returns, so it can be passed on some JSON module. |
* It stores string to its entries, even if its `outfile` is not truthy. * Flush emptied out the entries even if `outfile` is not truthy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented log flusing: it stores logs and writes to logfile on demand. This helps performance because file operations are locking. At cost of memory.
Using
love.filesystemif exist insteadio.Localized standard functions for efficiency.
Added debug info layer, in case this module get extended or used as a component of other module without rewriting things up.