Skip to content

Conversation

@diemol
Copy link
Member

@diemol diemol commented Jul 4, 2020

Home page changes

home_page_changes

Project page changes

project_page_changes

Docs page changes

docs_page_changes

@diemol diemol changed the title Adressing petres comments Adressing petres comments for desktop (responsive hero is still pending) Jul 4, 2020
@diemol diemol requested a review from christian-bromann July 4, 2020 22:30
@diemol diemol marked this pull request as ready for review July 4, 2020 22:30
@diemol diemol requested a review from christian-bromann July 5, 2020 12:11
Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diego-saucelabs something is off with the header:

Screenshot 2020-07-06 at 09 34 37

vs.:

Screenshot 2020-07-06 at 09 34 47

@diemol
Copy link
Member Author

diemol commented Jul 6, 2020

Yeah, taking the social icons out broke it.
I left them back again and I am now redoing the hero part.

@diemol
Copy link
Member Author

diemol commented Jul 6, 2020

@christian-bromann
So this looks fine again, it is ready to be merged.

@diemol diemol requested a review from christian-bromann July 6, 2020 07:42
Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@diemol diemol merged commit e4ba5b5 into dev Jul 6, 2020
@diemol diemol deleted the adressing-petres-comments branch July 6, 2020 08:05
github-actions bot pushed a commit that referenced this pull request Jul 6, 2020
…ng) (#29)

* Removing unused images

* Using vector images for logos

* Removing social icons on hero

* More space between title and heading

* Moving values to its own partial

* Adjusting box shadow

* Adjusting font color

* Using vectors to avoid fuzzy look

* Fixing links and button look

* Fixing link styling for events

* Fixing blog text color and link

* Left align copyright

* Using text links for projects

* Adjusting blog summary shadow

* Fixing styles for docs

* Adjusting spacing, overwrite template

* Update static/sass/components/buttons.scss

Co-authored-by: Christian Bromann <[email protected]>

* Leaving social to avoid breaking the header

Co-authored-by: Christian Bromann <[email protected]> e4ba5b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants