Upgrades #1
Merged
Upgrades #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sbt script was failing because of an old version of scalac, so I just upgraded all the things.
puffnfresh
commented
Nov 22, 2018
| @@ -53,10 +53,10 @@ which is handy when working on a particular exercise: | |||
| ./sbt | |||
|
|
|||
| # Run the tests from a package containing the name "Id" | |||
| > testOnly "*Id*" | |||
| > testOnly *Id* | |||
There was a problem hiding this comment.
For some reason testOnly wasn't working when these things were quoted.
There was a problem hiding this comment.
Yeah not sure why I put the quotes in 👍
puffnfresh
commented
Nov 22, 2018
| @@ -20,9 +20,9 @@ scalacOptions := Seq( | |||
| "-deprecation" | |||
| , "-unchecked" | |||
| , "-Xfatal-warnings" | |||
| , "-Xlint" | |||
| , "-Xlint:_,-unused" | |||
There was a problem hiding this comment.
We don't want unused errors because the exercises import useful things but don't use them (until the exercises are implemented)
puffnfresh
commented
Nov 22, 2018
| @@ -18,10 +18,10 @@ declare -r latest_28="2.8.2" | |||
|
|
|||
| declare -r buildProps="project/build.properties" | |||
|
|
|||
| declare -r sbt_launch_ivy_release_repo="https://repo.typesafe.com/typesafe/ivy-releases" | |||
| declare -r sbt_launch_ivy_release_repo="http://repo.typesafe.com/typesafe/ivy-releases" | |||
There was a problem hiding this comment.
I redownloaded the sbt script. Weird change, happy to undo.
There was a problem hiding this comment.
Yeah I manually changed them to https, I don't know why Paul would want it to be http. We should probably push that change upstream.
|
💯 Thanks Brian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.