Move playback position in voice messages by holding down cursor and dragging #7309
+194
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows users to click and drag on the waveform to seek within voice messages. - Pauses playback during drag and resumes it if the audio was playing before. - Prevents multiple listeners and potential memory leaks by guarding drag state.
- Added unit tests for testing the interaction between waveform dragging and voice message playback.
jaspass04
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
and Contributor Guidelines
Contributor checklist:
npm run readyrun passes successfully (more about tests here)Voice Message Waveform Playback Position Dragging
Overview
This pull request implements the solution to the feature request of issue #7218 offering a waveform dragging functionality for voice messages in Signal Desktop, allowing users to seek through audio playback by dragging directly on the waveform visualization.
Before our implementation:
current-signal-voice-playback-.not-working.mov
After our implementation:
signal-voice-playback-working.mov
Features
Technical Implementation
Testing
Comprehensive tests have been added to verify:
User Experience Improvements
This enhancement provides a more intuitive way to navigate voice messages, particularly for longer recordings where precise positioning is important. Users can now:
The implementation follows established patterns for audio scrubbing found in popular media players, making the interaction familiar and intuitive for users.