Skip to content

Improve gossipsub module: fix typos, naming consistency and error handling #7641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

aso20455
Copy link

  1. Fixing typos in documentation:

    • "gurantees" → "guarantees"
    • "occuring" → "occurring"
  2. Improving naming consistency:

    • Renamed "gossip_retransimission" to "gossip_retransmission" throughout the codebase
  3. Enhancing error handling and safety:

    • Replaced unsafe unwrap()/expect() calls with safer alternatives
    • Added proper error handling for peer ID creation
    • Improved error messages for configuration errors

…dling

Improve gossipsub module: fix typos, naming consistency and error handling
@aso20455 aso20455 requested a review from jxs as a code owner June 24, 2025 15:57
Copy link

cla-assistant bot commented Jun 24, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jun 24, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aso20455 aso20455 changed the title Improve gossipsub module: fix typos, naming consistency and error han… Improve gossipsub module: fix typos, naming consistency and error handling Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant