Code tidy #24
Open
Code tidy #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecken/Simple.OData.Client into maxbruecken-fix-expanding-of-children
…lient into houbi56-filterbug
…mple.OData.Client into fluentapi_httpheaders
… and not ResolvedCommand.
s/new (.+)\[\s*\]\s*\{\s*\}/Array.Empty<$1>()/
…g semaphore and semaphoreLimiter to RequestRunner.
Remove unnecessary CancellationToken IsCancellationRequested check, as it is already checked inside ThrowIfCancellationRequested (https://github.com/dotnet/runtime/blob/release/7.0/src/libraries/System.Private.CoreLib/src/System/Threading/CancellationToken.cs#L359-L363)
Unnecessary CancellationToken checks
Add rate-limiting to outgoing requests.
Improving performance via pattern-matching for nulls where possible.
- Alphabetization - Nest constructors - Add IgnoreNavigationPropertiesOnUpdate - Allows null navigation properties to be ignored on update. - Associated unit tests.
- .NET 8.0, .NET 7.0, and .NET Standard 2.0 Support solution-wide - Move more code artifacts into the `src` folder (having source outside of `src` is weird) - Move the "Dynamic" project into Core - Dramatically expand Directory.Build.props - Simplify and standardize project file layout - Create a "Package-Only" project for the Metapackage - Pin NuGet references to the latest minor versions on build - Remove ConfigureAwaits from unit tests (per xunit Analyzer) - Remove unnecessary usings - Added package readmes to every deployable project - Restored certain code paths from previous builds on platforms that cannot leverage new language features (like array slicing shortcuts) - Fixed an issue where XML resources were not being updated by the compiler. - Reduced over 2000 warnings down to about 700 TODO: - One unit test fails on .NET 4.8 - Ready for CI integration
Solution Modernization (Part 1) - What a tedious review! All looks good though.
This reverts commit 55123f6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest C#12 standards for code analysis