Skip to content

Gh 265 auto completion #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Gh 265 auto completion #272

wants to merge 15 commits into from

Conversation

speak-mentaiko
Copy link

Resolves

What Github issue does this resolve (please include link)?

  • Resolves #

Proposed Changes

Describe what this Pull Request does

Reason for Changes

Explain why these changes should be made

Test Coverage

Please show how you have added tests to cover your changes

Browser Coverage

Check the OS/browser combinations tested (At least 2)

Mac

  • Chrome
  • Firefox
  • Safari

Windows

  • Chrome
  • Firefox
  • Edge

Chromebook

  • Chrome

iPad

  • Safari

Android Tablet

  • Chrome

@laminne laminne force-pushed the gh-265-auto-completion branch from 7f31691 to 2302789 Compare December 11, 2020 08:29
@takaokouji
Copy link

takaokouji commented Dec 14, 2020

@Miyawaki-raku
#273
などを参考にして、このPRの最初のコメントを修正して下さい。

あと、 @riversunlight の修正 https://github.com/smalruby/smalruby3-gui/pull/268/files を参考にして、コーディングスタイル (プログラムの書き方) のエラーを修正して下さい。

具体的には以下のように修正します。

修正できたら、再度 git push コマンドを実行して下さい。

@takaokouji takaokouji force-pushed the gh-265-auto-completion branch from ba98050 to 905647e Compare October 13, 2023 22:52
@takaokouji
Copy link

こちらは手動でマージしましたので、closeします。

@takaokouji takaokouji closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants