Scratch 3.0をマージしました #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release August 10 to Beta
Note: the coming soon tooltip positions are calculated by react-tooltip, and they do not handle RTL.
Don’t intialize cards position in reducer - position needs to be set based on isRtl. Rename prev/next icons to right/left arrows Make `NextPrevButtons` function RTL aware so that it puts the prev/next on the left or right based on the direction of the language.
…k-link [Master] Update Give Feedback link
…k-link [Develop] Update Give Feedback link
Also just cleaner formatting of the connect in the `errorBoundary` container
…758-cards-rtl Handle RTL for cards
…757-menubar Handle RTL in menubar
*Kind of*. This isn't a good way to do it because we use the storage singleton before GUI is mounted. This needs to happen differently, like configuring storage in the project loader hoc and passing it down, so it could be attached to the VM once it has a VM? Fixup 723d975 This reverts commit 723d975.
We don't have revisions
…ckpack Add project and asset host props
…-restore-sprite Revert "Merge pull request scratchfoundation#2845 from kchadha/disable-sprite-restore"
…759-modals Handle RTL in modals
…se.20180817005452
…h-blocks-0.1.0-prerelease.1534442955 Update scratch-blocks to the latest version 🚀
…h-vm-0.2.0-prerelease.20180816213529 chore(package): update scratch-vm to version 0.2.0-prerelease.2018081…
…h-paint-0.2.0-prerelease.20180816205442 chore(package): update scratch-paint to version 0.2.0-prerelease.2018…
…erelease.20180817005452
…h-svg-renderer-0.2.0-prerelease.20180817005452 Update scratch-svg-renderer to the latest version 🚀
Remove the default prop test because the default projectId prop comes from redux now, so it doesn't make sense to test the default Lint
Fastly is not configured yet
Update enzyme, paint, vm, style-loader, and webpack-cli packages
…3-mirror-speaker Mirror the speaker icon for RTL languages
…2-extension-padding Fix connection modal padding for RTL
…h-vm-0.2.0-prerelease.20180830155110 Update scratch-vm to the latest version 🚀
…h-blocks-0.1.0-prerelease.1535652659 Update scratch-blocks to the latest version 🚀
Just use ProjectLoaderHOC to translate props to redux. Trying to be clever about using both props and redux state together was... not clever. Resolves scratchfoundation#3040
Don't load the default project on top of everything
…h-blocks-0.1.0-prerelease.1535662135 Update scratch-blocks to the latest version 🚀
…h-l10n-3.0.20180830210150 Update scratch-l10n to the latest version 🚀
Add Intl to Crash Message Component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
本家の方でも確認できますので、本家のバグです。
eslintのテストでエラーが出るようになります。