small fix disableDigests to disableDigest as docs #10866
Conversation
|
Waiting for approval from someone in the solo-io org to start testing. |
|
Issues linked to changelog: |
sam-heilbron
left a comment
sam-heilbron
left a comment
There was a problem hiding this comment.
@NewtonMan Thanks for the contribution! We'll have someone from a team take a look shortly and provide feedback
| @@ -0,0 +1,6 @@ | |||
| changelog: | |||
There was a problem hiding this comment.
Thank you for the PR. I see this PR was created 5 days ago and you were correct to put the changelog in beta4; however, beta4 got released 3 days ago. If you can move this to changelog/v1.20.0-beta5/fix-disabledigest-typo.yaml. I can approve.
There was a problem hiding this comment.
@andy-fong please can you tell me where to place right now? I didn't get that review in time. So let me know and I will update this PR.
There was a problem hiding this comment.
currently, it should go to v1.20.0-beta9. The way to tell is:
- merge latest main
- git describe --tags --abbrev=0 origin/main will tell you the last release tag
- add 1 to the patch or minor number of last release
3 participants
This PR updates the configuration to use the correct parameter for disabling digest verification on images.
Previously, both disableDigest: true and disableDigests: true were being set. However, after reviewing the documentation, there is no mention of the plural form (disableDigests). Upon inspecting recent commits, it appears this parameter was only recently introduced.
To maintain consistency with the documented and expected configuration, this PR renames disableDigests to the singular form disableDigest.