3.x

[bram-pkg]

As promised in #57, here's a PR that makes the codebase a lot more modern.

@freekmurze what do you think about the minimum PHP version? Same as the minimum of L12?

Breaking changes are mainly if you override the GTM class, you'll need to add types.

I also removed support for the "macroPath" config option, which seemed a bit silly considering users can just implement that themselves by doing a require_once in their AppServiceProvider.

[freekmurze]

This looks very good, thanks! 👍

what do you think about the minimum PHP version? Same as the minimum of L12?
Generally speaking I don't mind requiring the latest and greatest version of PHP for a package / new major

Could you either update the PHP restraint in composer.json to PHP 8.4 or update the test workflow to run tests for 8.2, 8.3, 8.4

Could you also add an UPGRADE.md file with upgrade instructions for current users? Can be a rough description of the changes needed.

[bram-pkg]

Hi, I'll make an UPGRADE.md, and the tests already run at 8.2, 8.3, and 8.4? I think you might have been looking at the static analysis workflow - which is probably fine to only run on one version?

[bram-pkg]

Added an upgrade guide now, I checked other spatie repos and they seem to call it "UPGRADING.md" so I just followed that convention.

[freekmurze]

Hi, I'll make an UPGRADE.md, and the tests already run at 8.2, 8.3, and 8.4? I think you might have been looking at the static analysis workflow - which is probably fine to only run on one version?

Ah yes indeed... That's fine!

[freekmurze]

Thanks!