Skip to content

Fix ResultColumnMixin - add table reference for QueryResult #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025

Conversation

griffio
Copy link
Contributor

@griffio griffio commented Jun 24, 2025

QueryResult.table was being hardcoded as null, add the table reference so that queryExposed() collection elements QueryResult.table can be used to determine the result column's table or table alias.

e.g Query Table reference could also be a TableAlias element.

SELECT *
FROM Orders o
JOIN OrderLines ol USING (order_id)

  • CHANGELOG.md's "Unreleased" section has been updated, if applicable.

griffio added 2 commits June 24, 2025 14:51
QueryResult.table was being hardcoded as `null`, add the table reference so that `queryExposed()` QueryResult.table can be used

Table reference could also be a TableAlias element.
@griffio griffio marked this pull request as ready for review June 24, 2025 14:47
@JakeWharton JakeWharton merged commit 0121554 into sqldelight:master Jun 24, 2025
1 check passed
@griffio griffio deleted the fix-ResultColumnMixin-table branch June 24, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants