Skip to content

Conversation

@mattf1n
Copy link

@mattf1n mattf1n commented Jul 10, 2024

Issue #29 describes the problem. To fix it, we use a field with a default_factory.

@srush
Copy link
Owner

srush commented Jul 14, 2024

This looks great. Was planning on updating to Python 3.10 minimum this summer since there are some nice type system improvements.

Is there a reason it is a draft?

@mattf1n mattf1n marked this pull request as ready for review July 16, 2024 19:05
@mattf1n
Copy link
Author

mattf1n commented Jul 16, 2024

I put it as a draft because I didn't do any testing, just made the minimal edit so that I could import again and run my code. I will promote it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants