Skip to content

fix: ecs service support non default clusters #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2021
Merged

fix: ecs service support non default clusters #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions tfdevops/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,7 @@ def cfn(module, template, resources, types, s3_path, state_file):
props = translator.get_properties(r)
if props is None:
continue
props = filter_empty(props)
ctemplate["Resources"][rname] = {
"Type": cfn_type,
"DeletionPolicy": "Retain",
Expand Down Expand Up @@ -682,11 +683,14 @@ class EcsService(Translator):
tf_type = "ecs_service"
id = "ServiceName"
flatten = ("network_configuration", "deployment_controller")
rename = {"iam_role": "Role", "enable_ecs_managed_tags": "EnableECSManagedTags"}
rename = {
"iam_role": "Role",
"enable_ecs_managed_tags": "EnableECSManagedTags",
"cluster": "Cluster",
}
strip = (
"deployment_circuit_breaker",
"propagate_tags",
"cluster",
"deployment_maximum_percent",
"deployment_minimum_healthy_percent",
)
Expand Down Expand Up @@ -874,5 +878,19 @@ def get_properties(self, tf):
return cfr


def filter_empty(d):
if isinstance(d, list):
for v in list(d):
if isinstance(v, dict):
filter_empty(v)
elif isinstance(d, dict):
for k, v in list(d.items()):
if not v:
del d[k]
elif isinstance(v, (dict, list)):
filter_empty(v)
return d


if __name__ == "__main__":
cli()