Minor Java cleanups: #160
Minor Java cleanups: #160
Conversation
mimaison
commented
Oct 13, 2025
mimaison
commented
- Use Admin instead of AdminClient
- Use Map.of/List.of instead of Collections/Arrays
- Use constants for Kafka client configs
- Remove ZooKeeper mentions
- Clean some Javadoc
- Use Admin instead of AdminClient - Use Map.of/List.of instead of Collections/Arrays - Use constants for Kafka client configs - Remove ZooKeeper mentions - Clean some Javadoc Signed-off-by: Mickael Maison <[email protected]>
| ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, systemUnderTest.getBootstrapServers(), | ||
| ConsumerConfig.GROUP_ID_CONFIG, "tc-" + UUID.randomUUID(), | ||
| ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, OffsetResetStrategy.EARLIEST.name().toLowerCase(Locale.ROOT) | ||
| ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "earliest" |
There was a problem hiding this comment.
OffsetResetStrategy is deprecated since 4.0: https://kafka.apache.org/41/javadoc/org/apache/kafka/clients/consumer/OffsetResetStrategy.html.
There seems to be an issue as the recommended replacement AutoOffsetResetStrategy is not part of the public API. Tracking that in upstream Kafka.
There was a problem hiding this comment.
Yeah, it does feel like something slipped through the design cracks => I mean deprecating OffsetResetStrategy makes sense, but introducing AutoOffsetResetStrategy without exposing it in the public API kind of defeats the purpose. So the plan would be to add AutoOffsetResetStrategy to the public API or from now we would use pure strings?
There was a problem hiding this comment.
It seems the plan is to keep OffsetResetStrategy deprecated and not advertise AutoOffsetResetStrategy in the javadoc as it's for internal usages only. So users will now need to hard code earliest/latest.
2 participants
