feat: periodically check auth_query creds #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauleth
reviewed
Oct 25, 2024
| @interval :timer.seconds(15) | ||
|
|
||
| def start_link(args) do | ||
| name = {:via, Registry, {Supavisor.Registry.Tenants, {:secret_checker, args.id}}} |
Contributor
There was a problem hiding this comment.
Do we need that registry at all? It doesn't seem to be used for anything.
Contributor
Author
There was a problem hiding this comment.
yep, it can be very useful during debugging
Contributor
There was a problem hiding this comment.
I am not 100% sure if it is good approach. Maybe we could use Process.set_label/1 in the future instead?
| end | ||
|
|
||
| def terminate(_, state) do | ||
| :gen_statem.stop(state.conn) |
Contributor
There was a problem hiding this comment.
Weird that Postgrex do not offer Postgrex.stop/1 function. Maybe it would be worth adding such function upstream?
Contributor
Author
There was a problem hiding this comment.
yeah, I've been wanting to add this PR to Postgrex for a long time
Co-authored-by: Łukasz Jan Niemier <[email protected]>
hauleth
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.