Skip to content

Conversation

@J0
Copy link
Contributor

@J0 J0 commented Apr 24, 2023

What kind of change does this PR introduce?

Drive by contribution since the workflow seems similar to what we have in Auth. Aims to fix #13 , let me know if anything should be amended

How this was tested:

Additional Notes

The action needs to be granted write permissions to upload the binaries - Settings > Actions > Workflow Permissions > Read and Write Permissions

@J0 J0 marked this pull request as ready for review April 25, 2023 03:42
@J0 J0 requested a review from abc3 April 25, 2023 03:43
@chasers
Copy link
Contributor

chasers commented Apr 25, 2023

Super helpful thanks @J0! Curious, was the binary building for you?

@abc3 and I do not love the tagging you have to do in commits with this semver action.

I was going to try automating release notes with Github and pulling the version from the mix.exs file. Or pulling the version from a VERSION file into mix.exs and have the Github stuff run off the VERSION file.

Logflare has a VERSION file we do things with.

Realtime has a mix version check so it reminds us to update the version there too.

Maybe you can break this PR up into two? One that gets the binary building on releases. And then we can setup a draft one to flesh out the semver release workflow when @abc3 is back next week?

FYI, we are also wanting to setup multi-stage deployments with Actions like: https://www.youtube.com/watch?v=sVl6De94evo

@J0
Copy link
Contributor Author

J0 commented Apr 28, 2023

Hey @chasers,

Thanks for the swift reply! Sorry for the delayed response - it's been a busy week. I'll look at all the Github Actions related issues at one go tomorrow - feel free to ping me if I don't get back to you - feel free to ping me if I don't get back by Sun PT

@J0 J0 marked this pull request as draft April 30, 2023 13:15
@J0
Copy link
Contributor Author

J0 commented Apr 30, 2023

Seems like the binary does not build for me. Running into an error on the build when replacing ERTS binaries - if anyone has suggestions do let me know.

Reverting to draft for now.

Upd: going to file an issue against Burrito

@J0
Copy link
Contributor Author

J0 commented May 3, 2023

Opened an issue here: burrito-elixir/burrito#90

@J0
Copy link
Contributor Author

J0 commented May 9, 2023

Going to close for now until the linked issue is resolved

@J0 J0 closed this May 9, 2023
@J0 J0 reopened this May 24, 2023
@J0 J0 closed this May 31, 2023
@J0 J0 reopened this Jul 2, 2023
@J0 J0 marked this pull request as ready for review July 16, 2023 15:46
@J0 J0 requested a review from chasers July 16, 2023 15:48
@J0
Copy link
Contributor Author

J0 commented Jul 16, 2023

Hey team,

This took quite a while - had to resolve some dependency issues. Was hoping to close this out - wondering if y'all could take a look whenever a slot frees up and see if this is what y'all had in mind.

Thanks!

@J0
Copy link
Contributor Author

J0 commented Jul 18, 2023

Hey @chasers @abc3,

Not urgent, but just bumping in case it was missed - could I trouble y'all for a review on this whenever free? Let me know!

@J0
Copy link
Contributor Author

J0 commented Aug 18, 2023

Hey @chasers @abc3,

I'm going to close this for now as it's been sitting for a while but let me know if it's ever relevant in the future and we can re-open.

Thanks!

@J0 J0 closed this Aug 18, 2023
@J0 J0 reopened this Aug 29, 2023
@chasers chasers changed the title feat: add release workflow feat: add release workflow for burrito Aug 29, 2023
Copy link
Contributor

@abc3 abc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll block this until we make sure it works on all claimed platforms

@J0
Copy link
Contributor Author

J0 commented Aug 29, 2023

As discussed internally, let's table this for now

@J0 J0 closed this Aug 29, 2023
@hauleth hauleth deleted the j0/add_release_workflow branch January 8, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Github Action for executable binary compilation

4 participants