-
-
Notifications
You must be signed in to change notification settings - Fork 87
feat: add release workflow for burrito #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Super helpful thanks @J0! Curious, was the binary building for you? @abc3 and I do not love the tagging you have to do in commits with this semver action. I was going to try automating release notes with Github and pulling the version from the mix.exs file. Or pulling the version from a VERSION file into mix.exs and have the Github stuff run off the VERSION file. Logflare has a VERSION file we do things with. Realtime has a mix version check so it reminds us to update the version there too. Maybe you can break this PR up into two? One that gets the binary building on releases. And then we can setup a draft one to flesh out the semver release workflow when @abc3 is back next week? FYI, we are also wanting to setup multi-stage deployments with Actions like: https://www.youtube.com/watch?v=sVl6De94evo |
|
Hey @chasers, Thanks for the swift reply! Sorry for the delayed response - it's been a busy week. I'll look at all the Github Actions related issues at one go tomorrow - feel free to ping me if I don't get back to you - feel free to ping me if I don't get back by Sun PT |
|
Seems like the binary does not build for me. Running into an error on the build when replacing ERTS binaries - if anyone has suggestions do let me know. Reverting to draft for now. Upd: going to file an issue against Burrito |
|
Opened an issue here: burrito-elixir/burrito#90 |
|
Going to close for now until the linked issue is resolved |
|
Hey team, This took quite a while - had to resolve some dependency issues. Was hoping to close this out - wondering if y'all could take a look whenever a slot frees up and see if this is what y'all had in mind. Thanks! |
abc3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll block this until we make sure it works on all claimed platforms
|
As discussed internally, let's table this for now |
What kind of change does this PR introduce?
Drive by contribution since the workflow seems similar to what we have in Auth. Aims to fix #13 , let me know if anything should be amended
How this was tested:
Additional Notes
The action needs to be granted write permissions to upload the binaries - Settings > Actions > Workflow Permissions > Read and Write Permissions