Skip to content

Conversation

@e-minguez
Copy link
Collaborator

No description provided.

@e-minguez e-minguez requested a review from hardys June 18, 2025 08:36
@e-minguez e-minguez changed the title First attempt of some best practices First attempt of some Git/GitHub best practices Jun 18, 2025
@e-minguez e-minguez force-pushed the git-best-practices branch from 13afa04 to 1505c4f Compare June 18, 2025 10:14
alknopfler
alknopfler previously approved these changes Jun 18, 2025
Copy link
Contributor

@alknopfler alknopfler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we can improve it later on

@fdegir
Copy link
Contributor

fdegir commented Jun 18, 2025

Does it make sense to include below items into the doc?

  • Commit message guidelines (e.g., subject line limit, use of passive form)
  • The importance of atomic commits
  • How charts from PRs can be published for local testing

@e-minguez
Copy link
Collaborator Author

Does it make sense to include below items into the doc?

  • Commit message guidelines (e.g., subject line limit, use of passive form)
  • The importance of atomic commits
  • How charts from PRs can be published for local testing

Of course, would you mind sending a follow up PR for that or a suggestion over here? :)

@fdegir
Copy link
Contributor

fdegir commented Jun 18, 2025

Will send a new PR once the initial version is in.

@e-minguez e-minguez merged commit 76f3abe into suse-edge:main Jun 18, 2025
1 check passed
@e-minguez e-minguez deleted the git-best-practices branch June 18, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants