- 
                Notifications
    You must be signed in to change notification settings 
- Fork 40
Drop kube-controller-manager workaround #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop kube-controller-manager workaround #792
Conversation
It's been identified that the use of EIB Kubernetes manifests mechanism to update the HelmChartConfigs for the core Helm charts results in race condition, causing the Kubernetes kube-controller-manager to throw an unhandled exception due to both RKE2 HelmController and kube-controller-manager to operate on the same resource. To avoid triggering the issue, EIB documentation must be updated to instruct users **not** to use EIB Kubernetes manifests and instead use EIB **os-files**.
| @hardys @dbw7 I'm not sure if we already have the EIB documentation updated to instruct users about the use of EIB Kubernetes manifest mechanism for updating HelmChartConfigs causing the race condition. If not, it should perhaps be done. It can perhaps be explicitly stated in the release notes as well once EIB documentation is updated. | 
| I discussed this with @dbw7 - I think we need to ensure the  I guess this can be a general note related to configuration of core charts, and we definitely need to check here and https://github.com/suse-edge/atip to ensure any examples are handled correctly and are aligned with what we've found to work in SV. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to do, just merged in main for EIB and backported to 1.1 and 1.2.
This aligns with suse-edge/edge-image-builder#764 which was the resolution for the issues discussed in rancher/rke2#8357 Also related to suse-edge#792
| Pushed #802 which adjusts what I think is the only relevant example in the docs, so we can merge that, then this PR and backport both to 3.3 | 
This aligns with suse-edge/edge-image-builder#764 which was the resolution for the issues discussed in rancher/rke2#8357 Also related to #792
This aligns with suse-edge/edge-image-builder#764 which was the resolution for the issues discussed in rancher/rke2#8357 Also related to suse-edge#792 (cherry picked from commit 368cff4)
This aligns with suse-edge/edge-image-builder#764 which was the resolution for the issues discussed in rancher/rke2#8357 Also related to #792 (cherry picked from commit 368cff4)
It's been identified that the use of EIB Kubernetes manifests mechanism to update the HelmChartConfigs for the core Helm charts results in race condition, causing the Kubernetes kube-controller-manager to throw an unhandled exception due to both RKE2 HelmController and kube-controller-manager to operate on the same resource.
To avoid triggering the issue, EIB documentation must be updated to instruct users not to use EIB Kubernetes manifests and instead use EIB os-files.
This PR is proposed to ensure the workaround can be dropped from main branch and backported to 3.3 for the upcoming maintenance release as use of os-files is successfully validated.