Skip to content

Conversation

@fdegir
Copy link
Contributor

@fdegir fdegir commented Aug 18, 2025

It's been identified that the use of EIB Kubernetes manifests mechanism to update the HelmChartConfigs for the core Helm charts results in race condition, causing the Kubernetes kube-controller-manager to throw an unhandled exception due to both RKE2 HelmController and kube-controller-manager to operate on the same resource.

To avoid triggering the issue, EIB documentation must be updated to instruct users not to use EIB Kubernetes manifests and instead use EIB os-files.

This PR is proposed to ensure the workaround can be dropped from main branch and backported to 3.3 for the upcoming maintenance release as use of os-files is successfully validated.

It's been identified that the use of EIB Kubernetes manifests mechanism to update
the HelmChartConfigs for the core Helm charts results in race condition, causing
the Kubernetes kube-controller-manager to throw an unhandled exception due to both
RKE2 HelmController and kube-controller-manager to operate on the same resource.

To avoid triggering the issue, EIB documentation must be updated to instruct users
**not** to use EIB Kubernetes manifests and instead use EIB **os-files**.
@fdegir fdegir requested review from dbw7 and hardys August 18, 2025 11:47
@fdegir
Copy link
Contributor Author

fdegir commented Aug 18, 2025

@hardys @dbw7 I'm not sure if we already have the EIB documentation updated to instruct users about the use of EIB Kubernetes manifest mechanism for updating HelmChartConfigs causing the race condition. If not, it should perhaps be done. It can perhaps be explicitly stated in the release notes as well once EIB documentation is updated.

@fdegir fdegir requested a review from dprodanov4 August 18, 2025 12:35
@hardys
Copy link
Contributor

hardys commented Aug 18, 2025

I discussed this with @dbw7 - I think we need to ensure the os-files workaround is actually documented somewhere before dropping the current workaround.

I guess this can be a general note related to configuration of core charts, and we definitely need to check here and https://github.com/suse-edge/atip to ensure any examples are handled correctly and are aligned with what we've found to work in SV.

Copy link
Contributor

@dbw7 dbw7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to do, just merged in main for EIB and backported to 1.1 and 1.2.

hardys added a commit to hardys/suse-edge.github.io that referenced this pull request Aug 21, 2025
This aligns with suse-edge/edge-image-builder#764
which was the resolution for the issues discussed in
rancher/rke2#8357

Also related to suse-edge#792
@hardys
Copy link
Contributor

hardys commented Aug 21, 2025

Pushed #802 which adjusts what I think is the only relevant example in the docs, so we can merge that, then this PR and backport both to 3.3

hardys added a commit that referenced this pull request Aug 21, 2025
This aligns with suse-edge/edge-image-builder#764
which was the resolution for the issues discussed in
rancher/rke2#8357

Also related to #792
@hardys hardys merged commit 4f082d8 into suse-edge:main Aug 21, 2025
1 check passed
hardys added a commit to hardys/suse-edge.github.io that referenced this pull request Aug 21, 2025
This aligns with suse-edge/edge-image-builder#764
which was the resolution for the issues discussed in
rancher/rke2#8357

Also related to suse-edge#792

(cherry picked from commit 368cff4)
hardys added a commit that referenced this pull request Aug 21, 2025
This aligns with suse-edge/edge-image-builder#764
which was the resolution for the issues discussed in
rancher/rke2#8357

Also related to #792

(cherry picked from commit 368cff4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants