forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 341
[DebugInfo] Emit specifiction_of and spare bits mask in debug info #8170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
augusto2112
wants to merge
2
commits into
swiftlang:stable/20230725
Choose a base branch
from
augusto2112:spare-bits-mask-dwarf
base: stable/20230725
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DebugInfo] Emit specifiction_of and spare bits mask in debug info #8170
augusto2112
wants to merge
2
commits into
swiftlang:stable/20230725
from
augusto2112:spare-bits-mask-dwarf
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci test |
@swift-ci test macOS |
2979fe9
to
490b689
Compare
@swift-ci test |
490b689
to
020cd44
Compare
@swift-ci test |
020cd44
to
d229f19
Compare
@swift-ci test |
adrian-prantl
approved these changes
Feb 15, 2024
The spare bits mask is a mask of the unused bits that a type may have. Swift uses these on enums to pack extra data when wrapping these enums in other types. Emit this field in LLVM-IR and DWARF.
d229f19
to
d0c5c44
Compare
@swift-ci test |
@swift-ci test Windows |
1 similar comment
@swift-ci test Windows |
Add a specification_of attribute to LLVM DebugInfo, which is analogous to DWARF's DW_AT_specification. According to the DWARF spec: "A debugging information entry that represents a declaration that completes another (earlier) non-defining declaration may have a DW_AT_specification attribute whose value is a reference to the debugging information entry representing the non-defining declaration." This patch allows types to be specifications of other types. For example, a templated type where the template parameters are substituted in could be a specification of the non-substituted template type.
@swift-ci test |
@swift-ci test Windows |
adrian-prantl
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1:
Commit 2: