Enable more windows test and fix some failing ones #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveinglis
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
neonichu
reviewed
Feb 13, 2025
neonichu
approved these changes
Feb 13, 2025
owenv
approved these changes
Feb 13, 2025
|
@swift-ci test |
jakepetroules
requested changes
Feb 14, 2025
|
@swift-ci test |
daveinglis
force-pushed
the
pr/test_updates
branch
from
331df12 to
8260339
Compare
|
@swift-ci test |
daveinglis
force-pushed
the
pr/test_updates
branch
from
8260339 to
f62723e
Compare
|
@swift-ci test |
daveinglis
force-pushed
the
pr/test_updates
branch
2 times, most recently
from
be17ff3 to
cff72bc
Compare
|
@swift-ci test |
daveinglis
force-pushed
the
pr/test_updates
branch
from
cff72bc to
5511471
Compare
|
@swift-ci test |
jakepetroules
approved these changes
Feb 18, 2025
jakepetroules
requested changes
Feb 19, 2025
jakepetroules
added a commit
that referenced
this pull request
Feb 20, 2025
This contains a subset of the fixes in #158 to get to fully green, and also to try to debug discrepancies between Swift CI and my local machine.
| @@ -1137,7 +1137,7 @@ fileprivate struct BuildOperationTests: CoreBasedTests { | |||
| } | |||
|
|
|||
| /// Check some cancellation related semantics. | |||
| @Test | |||
| @Test(.skipHostOS(.windows, "requires /usr/bin/yes")) | |||
There was a problem hiding this comment.
Oddly this fails for me locally, but not on CI (note #199 Windows build is passing). Maybe due to nondeterministic cancellation timing?
- fixed issue where a request to build a single output would fail on windows due to path separator differences used in llbuild manifest.
CustomTaskBuildOperationTest - fixes for windows
Hmm, this passes for me locally... is this failing in CI? |
|
@swift-ci test |
daveinglis
force-pushed
the
pr/test_updates
branch
from
5511471 to
2c0915c
Compare
|
@swift-ci test |
|
@swift-ci test |
daveinglis
force-pushed
the
pr/test_updates
branch
from
2728198 to
07e856e
Compare
|
@swift-ci test |
jakepetroules
added a commit
that referenced
this pull request
Feb 20, 2025
This contains a subset of the fixes in #158 to get to fully green, and also to try to debug discrepancies between Swift CI and my local machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes are to the tests except one change in Sources/SWBBuildSystem/BuildOperation.swift where the path used needed to have posix paths separators also some update to the Windows.xcspec file
(rdar://142882894)