Require iconv for mbstring #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the mbstring polyfill using the iconv functions a lot, if not in all calls being done, code without iconv using this polyfill will break. As this repo also provides a polyfill for iconv I don't think this will be a breaking change.
|
the test failure is because one test is comparing the currencies in this polyfill with the ICU data available in symfony/intl, and symfony/intl has recently updated its data to ICU 76.1 which has added new currencies. |
|
@stof I assume there is no need for me to look into this regarding this PR? |
|
@jaapio you indeed don't need to care about the failures in the PHP 7.x jobs here. The jobs for 8.x have additional failures, but I don't think they are related to your change either. |
stof
approved these changes
Dec 21, 2024
xabbuh
approved these changes
Dec 22, 2024
chalasr
approved these changes
Dec 22, 2024
|
Thank you @jaapio. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the mbstring polyfill using the iconv functions a lot, if not in all calls being done, code without iconv using this polyfill will break.
As this repo also provides a polyfill for iconv I don't think this will be a breaking change.