fix: remove --turbo flag from dev script, add separate dev:turbo script #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where --turbo flag causes styling issues with shadcn/ui. The --turbo flag can cause compatibility issues with certain CSS frameworks. This change provides both options: regular dev and turbo dev.
1234-ad
requested review from
c-ehrlich,
juliusmarminge,
nexxeln and
t3dotgg
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #2145 where the
--turboflag in the dev script causes styling issues with shadcn/ui and potentially other CSS frameworks.Changes
--turboflag from the defaultdevscriptdev:turboscript for users who want to use turbo modeWhy this change?
The
--turboflag can cause compatibility issues with certain CSS frameworks like shadcn/ui, making debugging extremely difficult. By separating the turbo functionality into its own script, we:Testing
npm run devandnpm run dev:turbowork as expected