Decoupled providers from AWS and added a new default service #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor decouples the AWS and DeepL API integrations from the Streamlit app’s core logic.
A new OpenAI based provider has been added and set as the default for simplicity.
To add a new provider:
Implement a class under services/ that conforms to the following constructs:
Translator
(services/translation.py)TextToSpeech
(services/tts.py)Register the provider in
services/factory.py.Optionally, update the Streamlit app configuration to make your new provider the default.
Only the current default provider (OpenAI) has been tested so far, since access to AWS and DeepL is unavailable.
The code for the refactor was generated by @ChefTDD with my review and oversight.