Skip to content

Markup: Fixes from publication process meaningful from year-to-year #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gesa
Copy link
Member

@gesa gesa commented Jun 12, 2025

  • Add version line to metadata
  • Add PDF script for parity with ECMA-262
  • Subtle formatting fixes from 2024 and 2025 editions
  • Clarifying comment for future publishers (or myself next year)

@gesa gesa marked this pull request as draft June 12, 2025 12:16
- Add version line to metadata
- Add PDF script for parity with ECMA-262
- Subtle formatting fixes from 2024 and 2025 editions
- Clarifying comment for future publishers (or myself next year)
@gesa gesa changed the title Markup: Metadata and functionality for print generation Markup: Fixes from publication process meaningful from year-to-year Jun 12, 2025
@gesa gesa marked this pull request as ready for review June 12, 2025 12:36
spec/index.html Outdated
Comment on lines 35 to 40

/* These tables are too narrow for their captions */
#table-sanctioned-single-unit-identifiers table,
#table-listformat-resolvedoptions-properties table {
width: 102mm;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "table too narrow for its caption" actually a problem? And if so, could it be fixed in a more general way?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In print? Yeah, very much so that's a problem. In a multi-page print render, table caption widths end up constrained by table widths. This is a tradeoff we make so we can have consistent continuation captions when tables go beyond one page, but doesn't only impact long tables. So if a table is narrow and a caption is long, you end up with

Table N:
Lorem ipsum
dolor sit amet
consectetur
adipisicing
elit

I've picked the widths I've picked to try to balance table content with caption length but I'm not particularly attached to said widths.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still like to avoid them, and especially to avoid referencing specific tables by ID. Does this general approach work with Prince?

emu-figure figure, emu-example figure, emu-table figure {
    width: fit-content;
    margin-left: auto;
    margin-right: auto;
}

emu-figure figure .real-table, emu-example figure .real-table, emu-table figure .real-table {
    width: 100%;
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not how you'd hope. It works in that it makes all the tables 100% width as opposed to optimising for content, so it ultimately makes it less readable.

before
2506_qfuws

vs after
2506_nfhc6

Maybe this is a good time to remind you that we have full control over "viewport" size when we publish. We know, beyond the shadow of a doubt, that it's going to be 210mm with extremely predictable rendering. So it's not like different viewers are going to see different wraps on the table.

Also table width need to be audited every year, so it's not like and editor changing a table's ID for some reason is going to lead to an unreadable table slipping into the published standard—that'll only happen if the document is not checked first, irrespective of what tweaks were made in previous years.

Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants