Skip to content

fix(view): InvalidClosingTag should ignore commented out code attributes #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

erikaraujo
Copy link
Contributor

This PR introduces a failing test for #1287.

The issue seems to be a combination of the code being commented out and the /svg part of the xmlns attribute of the svg tag in the following snippet:

<h1>
    <!-- <svg xmlns="http://www.w3.org/2000/svg">
    </svg> -->
</h1>

@brendt brendt added this to the v1.0.0-beta.2 milestone Jun 24, 2025
@brendt
Copy link
Member

brendt commented Jun 24, 2025

I believe this was fixed with #1289 ?

@brendt
Copy link
Member

brendt commented Jun 24, 2025

Indeed, this was fixed. Gonna merge the PR though because an additional test is always good

@brendt brendt merged commit 3892651 into tempestphp:main Jun 24, 2025
77 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants