Fix gem abbreviate/sanitize error #439
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gem metadata methods have changed. Local builds of rails-asset gems were failing with an error:
"NoMethodError: undefined method abbreviate' for #Gem::Indexer:0x000000128f04f0
The #abbreviate and #sanitize methods were moved to the Gem::Specification class in version 2.5.0 (https://blog.rubygems.org/2015/11/03/2.5.0-released.html). I've adjusted the worker code to handle the class correctly with the current version. However, I couldn't get this to work without updating the Ruby version (or make it work with newer versions than 2.2.3 because I don't have time to track down all the potential issues). I see this PR as a minor bugfix but the whole thing should be updated to a more recent Ruby version.
I do not know if this will also fix the path/String issue described in #421 because I was unable to reproduce that issue locally, but I think it is a distinct possibility.