feat: Remove elastic_gpu_specifications and elastic_inference_accelerator

[Sander0542]

Description

With version 6 of the AWS provider it drops support for elastic_gpu_specifications and elastic_inference_accelerator. These blocks are no longer supported by AWS and have reached end of life in January 2024 and April 2024.

References

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_ElasticGpuSpecification.html
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_ElasticInferenceAccelerator.html

Motivation and Context

Since the blocks have reached end of life there is no reason to keep them in the module. It prevents us from upgrading this module to version 6 of the AWS provider.

After this PR has been merged we can revert #3384 to add support for version 6 of the AWS provider

Related to #3383
Related to #3384

Breaking Changes

There are breaking changes, because two variables are removed in the eks-managed-node-group and self-managed-node-group modules.

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request

[bryantbiggs]

These will be handled at the next breaking change

[dhavaln-able]

@Sander0542 @bryantbiggs this seems to be a breaking change for all of our builds where we are using aws provider version >5.97.0. Do we know when this changes are getting merged?

[Sander0542]

@Sander0542 @bryantbiggs this seems to be a breaking change for all of our builds where we are using aws provider version >5.97.0. Do we know when this changes are getting merged?

This fix will still keep support for version 5 of the AWS provider. By removing the two variables it has support for version 5 and version 6 simultaneously.

[dhavaln-able]

@Sander0542 so because we are using version >5.97.0 most of our builds are using version 6.0 and it fails due to above variable which are not supported for v6.0 anymore. Correct me if I am wrong.

[dhavaln-able]

@Sander0542 the errors we are getting is below on aws v6.0

09:47:59  │ 
09:47:59  │   on .terraform/modules/slr-eks.eks/modules/eks-managed-node-group/main.tf line 140, in resource "aws_launch_template" "this":
09:47:59  │  140:   dynamic "elastic_gpu_specifications" {
09:47:59  │ 
09:47:59  │ Blocks of type "elastic_gpu_specifications" are not expected here.
09:47:59  ╵
09:47:59  ╷
09:47:59  │ Error: Unsupported block type
09:47:59  │ 
09:47:59  │   on .terraform/modules/slr-eks.eks/modules/eks-managed-node-group/main.tf line 148, in resource "aws_launch_template" "this":
09:47:59  │  148:   dynamic "elastic_inference_accelerator" {
09:47:59  │ 
09:47:59  │ Blocks of type "elastic_inference_accelerator" are not expected here.
09:47:59  ╵
09:47:59  ╷
09:47:59  │ Error: Unsupported block type
09:47:59  │ 
09:47:59  │   on .terraform/modules/slr-eks.eks/modules/self-managed-node-group/main.tf line 201, in resource "aws_launch_template" "this":
09:47:59  │  201:   dynamic "elastic_gpu_specifications" {
09:47:59  │ 
09:47:59  │ Blocks of type "elastic_gpu_specifications" are not expected here.
09:47:59  ╵
09:47:59  ╷
09:47:59  │ Error: Unsupported block type
09:47:59  │ 
09:47:59  │   on .terraform/modules/slr-eks.eks/modules/self-managed-node-group/main.tf line 209, in resource "aws_launch_template" "this":
09:47:59  │  209:   dynamic "elastic_inference_accelerator" {
09:47:59  │ 
09:47:59  │ Blocks of type "elastic_inference_accelerator" are not expected here.```

[Sander0542]

@dhavaln-able because of version 6 you are getting these errors. Please have a look at issue #3383. It fixes has a workaround for the error.

[matthewsklein]

@bryantbiggs Thank you for updating the label and milestone. Does this indicate the next release will be v21.0.0 instead of another minor or patch? I saw the last major release was Feb 2nd of 2024, so my main question is trying to get a more concrete timeline on when to expect this fix to be merged and officially released. Thank you