Skip to content

No need to reshape here as all the data has been reshaped already. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wilderrodrigues
Copy link

The data is already reshaped in the beginning of the notebook, so no need to reshape it again when taking a random sample.

@wilderrodrigues
Copy link
Author

Hi @jonkrohn,

I'm following your online course on GANs and DRL. Got an issue executing your notebook. For example, I get weird loss/accuracy and the GAN simply doesn't work.

My code is a bit different, so I tried to run your and got the same results. I then tried running Grant's code, and still the same.

For instance, that's what I get after 500 epochs:

[D loss: 7.972398, acc: 0.500869]  [A loss: 0.032301, acc: 1.000000]

Any ideas?

Thanks in advance!

@jonkrohn
Copy link
Member

Hi @wilderrodrigues, GANs are famously finicky, but I have run this GAN code dozens of times without issue, including today. I suspect there is some difference between your code and the LiveLessons notebook. If not that, then some difference in the input data.

@jonkrohn jonkrohn closed this Mar 12, 2018
@wilderrodrigues
Copy link
Author

Thanks, @jonkrohn.

I also tried with Professor Rowel's code, but got similar results just like when running the code I wrote and your notebook. I'm running on a MacBook Pro, haven't tried on my GPU on AWS yet.

I will move on with the Reinforcement Learning part and look into this GAN issue later.

Thanks again!

Cheers, Wilder

@jonkrohn
Copy link
Member

Ok cool. It shouldn't matter what hardware you run the model on, but hopefully you stumble across the issue! You could post a StackOverflow question as well detailing your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants