-
Notifications
You must be signed in to change notification settings - Fork 52
Add specification for DLT_LIN #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So do you know whether this matches what Hannes Kaelber ([email protected], at the time he requested DLT_LIN) wanted when he requested DLT_LIN in this message? |
Can I assume from "This document is based on email conversation with Hannes Kaelber" that the answer is "yes"? |
|
So that translates to this sequence of octets: with the payload being an ISO 17987-2 N_PDU, as described in section 7.4 "Transport layer protocol data units", if message_type is 0 and with it being a 4-octet LIN Event type if message_type is 3? Is the LIN Event type big-endian or little-endian? |
|
What is the interpretation of the msg_format_rev field (a single integral value?), what values are supported, and what value corresponds to this format? For the checksum_type field, what does "unknown/error" indicate? Presumably the "classic" and "enhanced" checksum are as described in section 5.2.2.7 "Checksum" of ISO 17987-3:2016. Presumably the PID field is the protected identifier field preceding the first data field of the frame, as described in section 5.2.2.5 "PID field" of ISO 17987-3:2016. What types of error do the flags in the error field indicate?:
|
|
@guyharris Yes, this document as a copy of an email from Hannes Kaelber (the email is a translation of a German documentation he used), as far as your questions goes, I will have to re-contact him. Would you like that I put you email in CC? Few topics I can answer:
yes
yes
yes
In LIN a single Frame is co-written by the master and slave (the master writes the "header" on the bus, the slave writes the "body" on the bus (payload + CRC)), It is not separate Frames for request and response |
Yes, please. |
|
@guyharris I don't see an email address on your profile |
|
@guyharris Hannes Kaelber is in vacation until mid April, I will re-contact him when he is back. |
|
@guyharris document updated with Hannes Kälber feedback, good to merge? |
|
Please rebase on the current master branch if you can. |
# Conflicts: # style.css
|
@infrastation done |
| margin-top: 1px; | ||
| margin-bottom: 1px; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I'm surprised that we need new CSS, but hey if it makes this prettier... great!
|
Anything pending for this PR to be merged? |
No description provided.