Skip to content

Conversation

@luizluca
Copy link

No description provided.

@guyharris
Copy link
Member

So do all packets begin with a 6-octet destination address, a 6-octet source address, and a 2-octet Ethernet type of 0x8899?

And can you ever get a mixture of those packets and regular Ethernet packets when capturing?

@luizluca
Copy link
Author

So do all packets begin with a 6-octet destination address, a 6-octet source address, and a 2-octet Ethernet type of 0x8899?

AFAIK, yes. I couldn't capture any frame that does not follow that sequence. I even wrote a wireshark dissector (lua):

image

And can you ever get a mixture of those packets and regular Ethernet packets when capturing?

It is not expected. I guess the switch would drop a packet from the CPU port without the proprietary tag. It would not know how to forward it. If it was the CPU (linux) that received it, the current driver will warn and possibly drop it.

@infrastation
Copy link
Member

Please note that the packet diagrams, as they are now, display all fields 1 octet long (including MAC addresses and EtherType). To fix this, please look at the size ruler on the left side of the existing Marvell DSA packet diagram. Also it would be better to spell "Realktek" properly.

@luizluca
Copy link
Author

luizluca commented Dec 17, 2021

Please note that the packet diagrams, as they are now, display all fields 1 octet long (including MAC addresses and EtherType). To fix this, please look at the size ruler on the left side of the existing Marvell DSA packet diagram. Also it would be better to spell "Realktek" properly.

Oh, I see. The +6, +1... I'll add them. Thanks

If I do not use a custom DLT for this tag, where should I anchor a doc like this?

@infrastation
Copy link
Member

https://en.wikipedia.org/wiki/Realtek_Remote_Control_Protocol seems to be appropriate. It is possible to format packet diagrams nicely in Mediawiki (example), although I do not remember ever trying that. In the most basic case a PRE block with ASCII art would be better than nothing, I guess.

@luizluca
Copy link
Author

luizluca commented Jan 6, 2022

OK. Wikipedia it is. Thanks. Closing this PR

@luizluca luizluca closed this Jan 6, 2022
@luizluca
Copy link
Author

luizluca commented Jan 6, 2022

@guyharris
Copy link
Member

See print-realtek.c in the main branch; I took print-rrcp.c and modified it to handle protocols other than RRCP, and added references to some Realtek documents describing RRCP, RLDP, and REP packets, as well as something that might describe one form of Realtek tag.

If this doesn't make it into the Wikipedia (which it might not), then:

  • if there are Realtek documents available that describe the tag formats, please update print-realtek.c to handle those tag formats and point to the documents in question, mentioning where in the document the tag format is described;
  • if there aren't Realtek documents available that describe the tag formats, please update print-realtek.c to handle those tag formats and document them in the code, noting that they were determined by reverse engineering or however they were determined.

@guyharris guyharris changed the title Add Realtek Ethernet switch tag link-layer header types. Add support for printing Realtek Ethernet switch tags to print-realtek.c Jan 23, 2022
@guyharris
Copy link
Member

I'm reopening this for adding tag support to print-realtek.c. (I'd do it myself but I don't have files with which to test it.)

@guyharris guyharris reopened this Jan 23, 2022
@guyharris
Copy link
Member

Never mind, that's for tcpdump, not for tcpdump-htdocs.

@guyharris guyharris closed this Jan 23, 2022
@guyharris guyharris changed the title Add support for printing Realtek Ethernet switch tags to print-realtek.c Add Realtek Ethernet switch tag link-layer header types. Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants