-
Notifications
You must be signed in to change notification settings - Fork 17
Enable manual mode for entering password #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for this PR. This feature is quite useful. I have renamed |
@devdinu am thinking for making it an option like |
I would prefer to keep this PR simple as it is. We could use proper flags
Would still stay with |
|
Am leaning towards using an option instead of an env variable. Let me know if you can make the change and update the readme. |
@devdinu gentle ping |
@arunvelsriram Updated the code, could you test again and merge. |
@devdinu please rebase with master branch and squash the commits. The history is not clean and making it hard for reviewing. |
It's not working in my local machine.
Its trying read secret from a local file. The secret is now stored in OS X Keychain. Also please rebase and squash the commits to keep the history clean in master. |
@arunvelsriram Could you verify the functionality now, i've pushed some fixes. |
@devdinu I thought about another solution to this problem. If autofill enabled,
If autofill disabled,
What do you think? |
If autofill enabled, I wouldn't prefer to change my clipboard also we don't need it further, and we're copying to clipboard when its disabled. |
Fixed in #16 |
There's no sync between window opening and password input, This change makes the
enter
step manual with password in clipboard.