Skip to content

Enable manual mode for entering password #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

devdinu
Copy link
Contributor

@devdinu devdinu commented Oct 13, 2018

  • When there's delay in connecting to vpn, the password is entered in terminal

There's no sync between window opening and password input, This change makes the enter step manual with password in clipboard.

@arunvelsriram
Copy link
Member

Thanks for this PR. This feature is quite useful.

I have renamed MANUAL_MODE to AUTOFILL because I felt its short and more suitable. Can you mention about this feature in the readme?

@arunvelsriram
Copy link
Member

@devdinu am thinking for making it an option like lazy-connect -n. what do you think?

@devdinu
Copy link
Contributor Author

devdinu commented Oct 21, 2018

I would prefer to keep this PR simple as it is. We could use proper flags -disconnect, -connect -autofill etc later.

-n - doesn't reflect the functionality for me

Would still stay with lazyconnect by default connects to a vpn.

@arunvelsriram
Copy link
Member

-disconnect, -connect -autofill are hard to implement in shell script. Environment variable is lengthy so users might have to do an alias or use the history every time. -n is just an example we can use anything as an option.

@arunvelsriram
Copy link
Member

Am leaning towards using an option instead of an env variable. Let me know if you can make the change and update the readme.

@arunvelsriram
Copy link
Member

@devdinu gentle ping

@devdinu
Copy link
Contributor Author

devdinu commented Nov 13, 2018

@arunvelsriram Updated the code, could you test again and merge.

@arunvelsriram
Copy link
Member

@devdinu please rebase with master branch and squash the commits. The history is not clean and making it hard for reviewing.

@arunvelsriram
Copy link
Member

It's not working in my local machine.

cat: /Users/arunvelsriram/.config/lazy-connect/secret: No such file or directory
409:412: syntax error: Expected end of line but found real number. 

Its trying read secret from a local file. The secret is now stored in OS X Keychain.

Also please rebase and squash the commits to keep the history clean in master.

@devdinu
Copy link
Contributor Author

devdinu commented Dec 4, 2018

@arunvelsriram Could you verify the functionality now, i've pushed some fixes.

@arunvelsriram
Copy link
Member

@devdinu I thought about another solution to this problem.

If autofill enabled,

  1. pbcopy the TOTP
  2. Try to fill the password automatically

If autofill disabled,

  1. pbcopy the TOTP

What do you think?

@devdinu
Copy link
Contributor Author

devdinu commented Dec 4, 2018

If autofill enabled, I wouldn't prefer to change my clipboard also we don't need it further, and we're copying to clipboard when its disabled.

@arunvelsriram
Copy link
Member

Fixed in #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants