Remove pageviews query (growthbook#264)

Author: jdorn

config/config.sample.yml

@@ -20,14 +20,6 @@ datasources:
             context_location_country as country
           FROM
             experiment_viewed
-        pageviewsQuery: >
-          SELECT
-            user_id,
-            anonymous_id,
-            received_at as timestamp,
-            path as url
-          FROM
-            pages
       experimentDimensions:
         - country
 metrics:

packages/back-end/src/controllers/admin.ts

@@ -16,15 +16,11 @@ import uniqid from "uniqid";
 import { createDimension } from "../models/DimensionModel";
 import { getSourceIntegrationObject } from "../services/datasource";
 import { ExperimentInterface } from "../../types/experiment";
-import { createIdea } from "../services/ideas";
-import { createImpactEstimate } from "../models/ImpactEstimateModel";
-import { createPresentation } from "../services/presentations";
 import {
   getOrganizationsWithDatasources,
   createDataSource,
 } from "../models/DataSourceModel";
 import { POSTGRES_TEST_CONN } from "../util/secrets";
-import { PresentationSlide } from "../../types/presentation";
 import { processPastExperimentQueryResponse } from "../services/queries";
 
 export async function getOrganizations(req: AuthRequest, res: Response) {
@@ -92,13 +88,6 @@ export async function addSampleData(req: AuthRequest, res: Response) {
     variation_id
   FROM
     experiment_viewed`,
-        pageviewsQuery: `SELECT
-    user_id,
-    user_id as anonymous_id,
-    received_at as timestamp,
-    '' as url
-  FROM
-    pages`,
       },
     }
   );
@@ -369,48 +358,6 @@ export async function addSampleData(req: AuthRequest, res: Response) {
     })
   );
 
-  // Example idea
-  const estimate = await createImpactEstimate(
-    org.id,
-    signup.id,
-    "",
-    ".*",
-    153.429,
-    1901.71,
-    153.429,
-    "-- Traffic to selected pages\nSELECT\n  COUNT(DISTINCT user_id) as users\nFROM\n  pages\nWHERE\n  received_at >= '2020-11-13 16:26:12'\n  AND received_at <= '2020-11-20 16:26:12'\n  AND path ~ '.*';\n\n-- Entire site: Signup (binomial)\nWITH metric as (\n  SELECT\n    1 as value\n  FROM\n    pages u\n    JOIN signup m ON (\n      m.user_id = u.user_id\n      AND m.received_at >= u.received_at\n      AND m.received_at <= u.received_at + INTERVAL '3 days'\n    )\n  WHERE\n    u.received_at >= '2020-11-13 16:26:12'\n    AND u.received_at <= '2020-11-20 16:26:12'\n  GROUP BY\n    u.user_id\n)\nSELECT\n  SUM(value) as total\nFROM\n  metric;\n\n-- Selected pages only: Signup (binomial)\nWITH metric as (\n  SELECT\n    1 as value\n  FROM\n    pages u\n    JOIN signup m ON (\n      m.user_id = u.user_id\n      AND m.received_at >= u.received_at\n      AND m.received_at <= u.received_at + INTERVAL '3 days'\n    )\n  WHERE\n    u.received_at >= '2020-11-13 16:26:12'\n    AND u.received_at <= '2020-11-20 16:26:12'\n    AND u.path ~ '.*'\n  GROUP BY\n    u.user_id\n)\nSELECT\n  SUM(value) as value\nFROM\n  metric;",
-    "sql"
-  );
-  await createIdea({
-    text: "Add Facebook Login",
-    details: "We saw a huge lift when we added Login with Google",
-    estimateParams: {
-      estimate: estimate.id,
-      improvement: 10,
-      numVariations: 2,
-      userAdjustment: 100,
-    },
-    experimentLength: 18,
-    impactScore: 38,
-    votes: [],
-    tags: [],
-    organization: org.id,
-    userId: "growthbook",
-    userName: "Example User",
-  });
-
-  // Example presentation
-  const exp: PresentationSlide = {
-    id: evidence[0],
-    type: "experiment",
-  };
-  await createPresentation({
-    title: "Example A/B Test Review",
-    slides: [exp],
-    organization: org.id,
-    description: "",
-  });
-
   res.json({
     status: 200,
   });

packages/back-end/src/controllers/ideas.ts

@@ -41,13 +41,18 @@ export async function getIdeas(
 }
 
 export async function getEstimatedImpact(
-  req: AuthRequest<{ regex: string; metric: string; segment?: string }>,
+  req: AuthRequest<{ metric: string; segment?: string }>,
   res: Response
 ) {
-  const { regex, metric, segment } = req.body;
+  const { metric, segment } = req.body;
 
   const { org } = getOrgFromReq(req);
-  const estimate = await getImpactEstimate(org.id, metric, regex, segment);
+  const estimate = await getImpactEstimate(
+    org.id,
+    metric,
+    org.settings?.metricAnalysisDays || 30,
+    segment
+  );
 
   res.status(200).json({
     status: 200,
@@ -60,21 +65,17 @@ export async function postEstimatedImpactManual(
   res: Response
 ) {
   const { org } = getOrgFromReq(req);
-  const { value, metricTotal, users, metric, regex } = req.body;
+  const { conversionsPerDay, metric } = req.body;
 
   if (!metric) {
     throw new Error("Missing required metric.");
   }
 
-  const estimate = await createImpactEstimate(
-    org.id,
+  const estimate = await createImpactEstimate({
+    organization: org.id,
     metric,
-    null,
-    regex,
-    value,
-    users,
-    metricTotal
-  );
+    conversionsPerDay,
+  });
 
   res.status(200).json({
     status: 200,

packages/back-end/src/controllers/organizations.ts

@@ -923,8 +923,6 @@ export async function postDataSources(
       experimentEvent: "$experiment_started",
       experimentIdProperty: "Experiment name",
       variationIdProperty: "Variant name",
-      pageviewEvent: "Page view",
-      urlProperty: "$current_url",
       ...settings?.events,
     };
 
@@ -939,13 +937,16 @@ export async function postDataSources(
   variation_id
 FROM
   ${schema ? schema + "." : ""}experiment_viewed`,
-      pageviewsQuery: `SELECT
+      identityJoins: [
+        {
+          ids: ["user_id", "anonymous_id"],
+          query: `SELECT
   user_id,
-  anonymous_id,
-  received_at as timestamp,
-  path as url
+  anonymous_id
 FROM
-  ${schema ? schema + "." : ""}pages`,
+  ${schema ? schema + "." : ""}identifies`,
+        },
+      ],
       ...settings?.queries,
     };
 

packages/back-end/src/integrations/Athena.ts

@@ -27,12 +27,6 @@ export default class Athena extends SqlIntegration {
   ): string {
     return `${col} ${sign} INTERVAL '${amount}' ${unit}`;
   }
-  regexMatch(col: string, regex: string) {
-    return `regexp_like(${col}, '${regex}')`;
-  }
-  percentile(col: string, percentile: number) {
-    return `approx_percentile(${col}, ${percentile})`;
-  }
   formatDate(col: string): string {
     return `substr(to_iso8601(${col}),0,10)`;
   }

packages/back-end/src/integrations/BigQuery.ts

@@ -43,14 +43,6 @@ export default class BigQuery extends SqlIntegration {
       sign === "+" ? "ADD" : "SUB"
     }(${col}, INTERVAL ${amount} ${unit.toUpperCase()})`;
   }
-  regexMatch(col: string, regex: string) {
-    return `REGEXP_CONTAINS(${col}, "${regex}")`;
-  }
-  percentile(col: string, percentile: number) {
-    return `APPROX_QUANTILES(${col}, 100)[OFFSET(${Math.floor(
-      percentile * 100
-    )})]`;
-  }
   convertDate(fromDB: bq.BigQueryDatetime) {
     return getValidDate(fromDB.value + "Z");
   }

packages/back-end/src/integrations/ClickHouse.ts

@@ -60,12 +60,6 @@ export default class ClickHouse extends SqlIntegration {
   ): string {
     return `date${sign === "+" ? "Add" : "Sub"}(${unit}, ${amount}, ${col})`;
   }
-  regexMatch(col: string, regex: string) {
-    return `match(${col}, '${regex.replace(/\\/g, "\\\\")}')`;
-  }
-  percentile(col: string, percentile: number) {
-    return `quantile(${percentile})(${col})`;
-  }
   dateTrunc(col: string) {
     return `dateTrunc('day', ${col})`;
   }

packages/back-end/src/integrations/GoogleAnalytics.ts

@@ -1,7 +1,6 @@
 import {
   SourceIntegrationConstructor,
   SourceIntegrationInterface,
-  ImpactEstimationResult,
   MetricValueParams,
   ExperimentMetricQueryResponse,
   PastExperimentResponse,
@@ -73,7 +72,7 @@ const GoogleAnalytics: SourceIntegrationConstructor = class
     throw new Error("Method not implemented.");
   }
   getMetricValueQuery(params: MetricValueParams): string {
-    // TODO: support segments and url regex
+    // TODO: support segments
     return JSON.stringify(
       {
         viewId: this.params.viewId,
@@ -146,7 +145,6 @@ const GoogleAnalytics: SourceIntegrationConstructor = class
 
         dates.push({
           date,
-          users,
           count,
           mean,
           stddev,
@@ -198,10 +196,6 @@ const GoogleAnalytics: SourceIntegrationConstructor = class
     return client;
   }
 
-  async getImpactEstimation(): Promise<ImpactEstimationResult> {
-    throw new Error("Not implemented for GA");
-  }
-
   getExperimentResultsQuery(
     experiment: ExperimentInterface,
     phase: ExperimentPhase,